lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ath10k: avoid needless memset on TX path

Browse Source 
This reduces number of memory accesses and
hopefully contributes to better performance in the
future.

Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
This commit is contained in:
Michal Kazior
2013-09-18 14:43:19 +02:00
committed by Kalle Valo
parent 0945baf7d4
commit 27bb178dae
4 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/wireless/ath/ath10k/htc.c
View File

@@ -103,10 +103,10 @@ static void ath10k_htc_prepare_tx_skb(struct ath10k_htc_ep *ep,
struct ath10k_htc_hdr *hdr; struct ath10k_htc_hdr *hdr;
hdr = (struct ath10k_htc_hdr *)skb->data; hdr = (struct ath10k_htc_hdr *)skb->data;
memset(hdr, 0, sizeof(*hdr));
hdr->eid = ep->eid; hdr->eid = ep->eid;
hdr->len = __cpu_to_le16(skb->len - sizeof(*hdr)); hdr->len = __cpu_to_le16(skb->len - sizeof(*hdr));
hdr->flags = 0;
spin_lock_bh(&ep->htc->tx_lock); spin_lock_bh(&ep->htc->tx_lock);
hdr->seq_no = ep->seq_no++; hdr->seq_no = ep->seq_no++;

4
drivers/net/wireless/ath/ath10k/htt_tx.c
View File

@@ -384,9 +384,11 @@ int ath10k_htt_mgmt_tx(struct ath10k_htt *htt, struct sk_buff *msdu)
/* refcount is decremented by HTC and HTT completions until it reaches /* refcount is decremented by HTC and HTT completions until it reaches
* zero and is freed */ * zero and is freed */
skb_cb = ATH10K_SKB_CB(txdesc); skb_cb = ATH10K_SKB_CB(txdesc);
skb_cb->htt.is_conf = false;
skb_cb->htt.msdu_id = msdu_id; skb_cb->htt.msdu_id = msdu_id;
skb_cb->htt.refcount = 2; skb_cb->htt.refcount = 2;
skb_cb->htt.msdu = msdu; skb_cb->htt.msdu = msdu;
skb_cb->htt.txfrag = NULL;
res = ath10k_htc_send(&htt->ar->htc, htt->eid, txdesc); res = ath10k_htc_send(&htt->ar->htc, htt->eid, txdesc);
if (res) if (res)
@@ -505,7 +507,6 @@ int ath10k_htt_tx(struct ath10k_htt *htt, struct sk_buff *msdu)
skb_put(txdesc, desc_len); skb_put(txdesc, desc_len);
cmd = (struct htt_cmd *)txdesc->data; cmd = (struct htt_cmd *)txdesc->data;
memset(cmd, 0, desc_len);
tid = ATH10K_SKB_CB(msdu)->htt.tid; tid = ATH10K_SKB_CB(msdu)->htt.tid;
@@ -555,6 +556,7 @@ int ath10k_htt_tx(struct ath10k_htt *htt, struct sk_buff *msdu)
/* refcount is decremented by HTC and HTT completions until it reaches /* refcount is decremented by HTC and HTT completions until it reaches
* zero and is freed */ * zero and is freed */
skb_cb = ATH10K_SKB_CB(txdesc); skb_cb = ATH10K_SKB_CB(txdesc);
skb_cb->htt.is_conf = false;
skb_cb->htt.msdu_id = msdu_id; skb_cb->htt.msdu_id = msdu_id;
skb_cb->htt.refcount = 2; skb_cb->htt.refcount = 2;
skb_cb->htt.txfrag = txfrag; skb_cb->htt.txfrag = txfrag;

4
drivers/net/wireless/ath/ath10k/mac.c
View File

@@ -1757,7 +1757,9 @@ static void ath10k_tx(struct ieee80211_hw *hw,
ath10k_tx_h_seq_no(skb); ath10k_tx_h_seq_no(skb);
} }
memset(ATH10K_SKB_CB(skb), 0, sizeof(*ATH10K_SKB_CB(skb))); ATH10K_SKB_CB(skb)->is_mapped = false;
ATH10K_SKB_CB(skb)->is_aborted = false;
ATH10K_SKB_CB(skb)->htt.is_offchan = false;
ATH10K_SKB_CB(skb)->htt.vdev_id = vdev_id; ATH10K_SKB_CB(skb)->htt.vdev_id = vdev_id;
ATH10K_SKB_CB(skb)->htt.tid = tid; ATH10K_SKB_CB(skb)->htt.tid = tid;

1
drivers/net/wireless/ath/ath10k/txrx.c
View File

@@ -75,7 +75,6 @@ void ath10k_txrx_tx_unref(struct ath10k_htt *htt, struct sk_buff *txdesc)
ath10k_report_offchan_tx(htt->ar, msdu); ath10k_report_offchan_tx(htt->ar, msdu);
info = IEEE80211_SKB_CB(msdu); info = IEEE80211_SKB_CB(msdu);
memset(&info->status, 0, sizeof(info->status));
if (ATH10K_SKB_CB(txdesc)->htt.discard) { if (ATH10K_SKB_CB(txdesc)->htt.discard) {
ieee80211_free_txskb(htt->ar->hw, msdu); ieee80211_free_txskb(htt->ar->hw, msdu);