lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

UBI: Validate data_size

Browse Source 
Make sure that data_size is less than LEB size.
Otherwise a handcrafted UBI image is able to trigger
an out of bounds memory access in ubi_compare_lebs().

Cc: stable@vger.kernel.org
Signed-off-by: Richard Weinberger <richard@nod.at>
Reviewed-by: David Gstir <david@sigma-star.at>
This commit is contained in:
Richard Weinberger
2015-09-22 23:58:07 +02:00
parent cf6f54e3f1
commit 281fda2767
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/mtd/ubi/io.c
View File

@@ -926,6 +926,11 @@ static int validate_vid_hdr(const struct ubi_device *ubi,
goto bad; goto bad;
} }
if (data_size > ubi->leb_size) {
ubi_err(ubi, "bad data_size");
goto bad;
}
if (vol_type == UBI_VID_STATIC) { if (vol_type == UBI_VID_STATIC) {
/* /*
* Although from high-level point of view static volumes may * Although from high-level point of view static volumes may