lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

OMAP: PM: SmartReflex: Add missing IS_ERR test

Browse Source 
Function _sr_lookup, defined in the same file, returns ERR_PTR not NULL in
an error case.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier f;
@@
f(...) { ... return ERR_PTR(...); }

@@
identifier r.f, fld;
expression x;
statement S1,S2;
@@
 x = f(...)
 ... when != IS_ERR(x)
(
 if (IS_ERR(x) ||...) S1 else S2
|
*x->fld
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Kevin Hilman <khilman@ti.com>
This commit is contained in:
Julia Lawall
2011-01-24 20:55:22 +01:00
committed by Kevin Hilman
parent 1bae4ce27c
commit 28693ec01d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
arch/arm/mach-omap2/smartreflex.c
View File

@@ -966,7 +966,7 @@ static int __devexit omap_sr_remove(struct platform_device *pdev)
} }
sr_info = _sr_lookup(pdata->voltdm); sr_info = _sr_lookup(pdata->voltdm);
if (!sr_info) { if (IS_ERR(sr_info)) {
dev_warn(&pdev->dev, "%s: omap_sr struct not found\n", dev_warn(&pdev->dev, "%s: omap_sr struct not found\n",
__func__); __func__);
return -EINVAL; return -EINVAL;