lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

USB: remove bogus USB_PORT_FEAT_*_SPEED symbols

Browse Source 
This patch (as1348) removes the bogus
USB_PORT_FEAT_{HIGHSPEED,SUPERSPEED} symbols from ch11.h.  No such
features are defined by the USB spec.  (There is a PORT_LOWSPEED
feature, but the spec doesn't mention it except to say that host
software should never use it.)  The speed indicators are port
statuses, not port features.

As a temporary workaround for the xhci-hcd driver, a fictional
USB_PORT_STAT_SUPER_SPEED symbol is added.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
CC: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Alan Stern
2010-03-04 11:32:30 -05:00
committed by Greg Kroah-Hartman
parent 45f30e0bda
commit 288ead45fa
8 changed files with 23 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/usb/host/ehci.h
View File

@@ -556,20 +556,20 @@ ehci_port_speed(struct ehci_hcd *ehci, unsigned int portsc)
case 0:
return 0;
case 1:
return (1<<USB_PORT_FEAT_LOWSPEED);
return USB_PORT_STAT_LOW_SPEED;
case 2:
default:
return (1<<USB_PORT_FEAT_HIGHSPEED);
return USB_PORT_STAT_HIGH_SPEED;
}
}
return (1<<USB_PORT_FEAT_HIGHSPEED);
return USB_PORT_STAT_HIGH_SPEED;
}
#else
#define ehci_is_TDI(e) (0)
#define ehci_port_speed(ehci, portsc) (1<<USB_PORT_FEAT_HIGHSPEED)
#define ehci_port_speed(ehci, portsc) USB_PORT_STAT_HIGH_SPEED
#endif
/*-------------------------------------------------------------------------*/