lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

usb: gadget: u_uac1: NULL dereference on error path

Browse Source 
We should return here with an error code instead of continuing.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
Dan Carpenter
2013-02-28 07:44:38 +03:00
committed by Felipe Balbi
parent fddedd8334
commit 29240e2392
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/usb/gadget/u_uac1.c
View File

@@ -240,8 +240,11 @@ static int gaudio_open_snd_dev(struct gaudio *card)
snd = &card->playback; snd = &card->playback;
snd->filp = filp_open(fn_play, O_WRONLY, 0); snd->filp = filp_open(fn_play, O_WRONLY, 0);
if (IS_ERR(snd->filp)) { if (IS_ERR(snd->filp)) {
int ret = PTR_ERR(snd->filp);
ERROR(card, "No such PCM playback device: %s\n", fn_play); ERROR(card, "No such PCM playback device: %s\n", fn_play);
snd->filp = NULL; snd->filp = NULL;
return ret;
} }
pcm_file = snd->filp->private_data; pcm_file = snd->filp->private_data;
snd->substream = pcm_file->substream; snd->substream = pcm_file->substream;