lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ALSA: ctxfi: Use WARN_ON() instead of BUG_ON()

Browse Source 
BUG_ON() is rather useless for debugging as it leads to panic().
Use WARN_ON() and handle the error cases accordingly.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Iwai
2013-11-05 15:00:02 +01:00
parent 791b3f596e
commit 29fa957804
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
sound/pci/ctxfi/cthardware.c
View File

@@ -69,7 +69,8 @@ unsigned int get_field(unsigned int data, unsigned int field)
{ {
int i; int i;
BUG_ON(!field); if (WARN_ON(!field))
return 0;
/* @field should always be greater than 0 */ /* @field should always be greater than 0 */
for (i = 0; !(field & (1 << i)); ) for (i = 0; !(field & (1 << i)); )
i++; i++;
@@ -81,7 +82,8 @@ void set_field(unsigned int *data, unsigned int field, unsigned int value)
{ {
int i; int i;
BUG_ON(!field); if (WARN_ON(!field))
return;
/* @field should always be greater than 0 */ /* @field should always be greater than 0 */
for (i = 0; !(field & (1 << i)); ) for (i = 0; !(field & (1 << i)); )
i++; i++;