[NET]: Marking struct pernet_operations __net_initdata was inappropriate
It is not safe to to place struct pernet_operations in a special section. We need struct pernet_operations to last until we call unregister_pernet_subsys. Which doesn't happen until module unload. So marking struct pernet_operations is a disaster for modules in two ways. - We discard it before we call the exit method it points to. - Because I keep struct pernet_operations on a linked list discarding it for compiled in code removes elements in the middle of a linked list and does horrible things for linked insert. So this looks safe assuming __exit_refok is not discarded for modules. Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
72998d8c84
commit
2b008b0a8e
@@ -2668,7 +2668,7 @@ static void __net_exit dev_proc_net_exit(struct net *net)
|
||||
proc_net_remove(net, "dev");
|
||||
}
|
||||
|
||||
static struct pernet_operations __net_initdata dev_proc_ops = {
|
||||
static struct pernet_operations dev_proc_ops = {
|
||||
.init = dev_proc_net_init,
|
||||
.exit = dev_proc_net_exit,
|
||||
};
|
||||
@@ -4328,7 +4328,7 @@ static void __net_exit netdev_exit(struct net *net)
|
||||
kfree(net->dev_index_head);
|
||||
}
|
||||
|
||||
static struct pernet_operations __net_initdata netdev_net_ops = {
|
||||
static struct pernet_operations netdev_net_ops = {
|
||||
.init = netdev_init,
|
||||
.exit = netdev_exit,
|
||||
};
|
||||
@@ -4359,7 +4359,7 @@ static void __net_exit default_device_exit(struct net *net)
|
||||
rtnl_unlock();
|
||||
}
|
||||
|
||||
static struct pernet_operations __net_initdata default_device_ops = {
|
||||
static struct pernet_operations default_device_ops = {
|
||||
.exit = default_device_exit,
|
||||
};
|
||||
|
||||
|
@@ -285,7 +285,7 @@ static void __net_exit dev_mc_net_exit(struct net *net)
|
||||
proc_net_remove(net, "dev_mcast");
|
||||
}
|
||||
|
||||
static struct pernet_operations __net_initdata dev_mc_net_ops = {
|
||||
static struct pernet_operations dev_mc_net_ops = {
|
||||
.init = dev_mc_net_init,
|
||||
.exit = dev_mc_net_exit,
|
||||
};
|
||||
|
Reference in New Issue
Block a user