[PATCH] mark struct file_operations const 3
Many struct file_operations in the kernel can be "const". Marking them const moves these to the .rodata section, which avoids false sharing with potential dirty data. In addition it'll catch accidental writes at compile time to these shared resources. Signed-off-by: Arjan van de Ven <arjan@linux.intel.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
committed by
Linus Torvalds
parent
5dfe4c964a
commit
2b8693c061
@ -291,7 +291,7 @@ uncached_mmap(struct file *file, struct vm_area_struct *vma)
|
||||
return mspec_mmap(file, vma, MSPEC_UNCACHED);
|
||||
}
|
||||
|
||||
static struct file_operations fetchop_fops = {
|
||||
static const struct file_operations fetchop_fops = {
|
||||
.owner = THIS_MODULE,
|
||||
.mmap = fetchop_mmap
|
||||
};
|
||||
@ -302,7 +302,7 @@ static struct miscdevice fetchop_miscdev = {
|
||||
.fops = &fetchop_fops
|
||||
};
|
||||
|
||||
static struct file_operations cached_fops = {
|
||||
static const struct file_operations cached_fops = {
|
||||
.owner = THIS_MODULE,
|
||||
.mmap = cached_mmap
|
||||
};
|
||||
@ -313,7 +313,7 @@ static struct miscdevice cached_miscdev = {
|
||||
.fops = &cached_fops
|
||||
};
|
||||
|
||||
static struct file_operations uncached_fops = {
|
||||
static const struct file_operations uncached_fops = {
|
||||
.owner = THIS_MODULE,
|
||||
.mmap = uncached_mmap
|
||||
};
|
||||
|
Reference in New Issue
Block a user