lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[media] Correct error code from -ENOMEM to -EINVAL.

Browse Source 
Make sure the return value is set in all cases

>From 9b38a5c9878b5e4be2899ae291c4524f5f5fc218 Mon Sep 17 00:00:00 2001

Signed-off-by: Hans Petter Selasky <hselasky@c2i.net>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Hans Petter Selasky
2011-05-26 04:49:52 -03:00
committed by Mauro Carvalho Chehab
parent 5588dc2b02
commit 2c7988ab0e
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/media/video/sr030pc30.c
View File

@@ -726,8 +726,10 @@ static int sr030pc30_s_power(struct v4l2_subdev *sd, int on)
const struct sr030pc30_platform_data *pdata = info->pdata; const struct sr030pc30_platform_data *pdata = info->pdata;
int ret; int ret;
if (WARN(pdata == NULL, "No platform data!\n")) if (pdata == NULL) {
return -ENOMEM; WARN(1, "No platform data!\n");
return -EINVAL;
}
/* /*
* Put sensor into power sleep mode before switching off * Put sensor into power sleep mode before switching off
@@ -746,6 +748,7 @@ static int sr030pc30_s_power(struct v4l2_subdev *sd, int on)
if (on) { if (on) {
ret = sr030pc30_base_config(sd); ret = sr030pc30_base_config(sd);
} else { } else {
ret = 0;
info->curr_win = NULL; info->curr_win = NULL;
info->curr_fmt = NULL; info->curr_fmt = NULL;
} }