lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

S2io: two branches the same in wait_for_cmd_complete()

Browse Source 
Fix check to verify if a register bit is set. We have not hit this bug because
wait_for_cmd_complete() is always called with S2IO_BIT_RESET. 
Reported by Roel Kluin <roel.kluin@gmail.com>.

Signed-off-by: Ram Vepa <ram.vepa@neterion.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ram Vepa
2010-01-19 12:36:20 -08:00
committed by David S. Miller
parent dad48a4ef2
commit 2d146eb172
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/s2io.c
View File

@@ -3421,7 +3421,7 @@ static int wait_for_cmd_complete(void __iomem *addr, u64 busy_bit,
break; break;
} }
} else { } else {
if (!(val64 & busy_bit)) { if (val64 & busy_bit) {
ret = SUCCESS; ret = SUCCESS;
break; break;
} }