lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

generalize lgread_u32/lgwrite_u32.

Browse Source 
Jes complains that page table code still uses lgread_u32 even though
it now uses general kernel pte types.  The best thing to do is to
generalize lgread_u32 and lgwrite_u32.

This means we lose the efficiency of getuser().  We could potentially
regain it if we used __copy_from_user instead of copy_from_user, but
I'm not certain that our range check is equivalent to access_ok() on
all platforms.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: Jes Sorensen <jes@sgi.com>
This commit is contained in:
Rusty Russell
2007-10-22 11:24:24 +10:00
parent 56ae43dfe2
commit 2d37f94a28
7 changed files with 38 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/lguest/hypercalls.c
View File

@@ -47,7 +47,7 @@ static void do_hcall(struct lguest *lg, struct hcall_args *args)
char msg[128];
/* If the lgread fails, it will call kill_guest() itself; the
* kill_guest() with the message will be ignored. */
lgread(lg, msg, args->arg1, sizeof(msg));
__lgread(lg, msg, args->arg1, sizeof(msg));
msg[sizeof(msg)-1] = '\0';
kill_guest(lg, "CRASH: %s", msg);
break;