lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

signals: cleanup the usage of print_fatal_signal()

Browse Source 
Move the callsite of print_fatal_signal() down, under "if
(sig_kernel_coredump(signr))", so we don't need to check signr != SIGKILL.

We are only interested in the sig_kernel_coredump() signals anyway, and due to
the previous changes we almost never can see other fatal signals here except
SIGKILL.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Oleg Nesterov
2008-04-30 00:52:58 -07:00
committed by Linus Torvalds
parent 34c8f07b9a
commit 2dce81bff2
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
kernel/signal.c
View File

@@ -1787,9 +1787,10 @@ relock:
* Anything else is fatal, maybe with a core dump. * Anything else is fatal, maybe with a core dump.
*/ */
current->flags |= PF_SIGNALED; current->flags |= PF_SIGNALED;
if ((signr != SIGKILL) && print_fatal_signals)
print_fatal_signal(regs, signr);
if (sig_kernel_coredump(signr)) { if (sig_kernel_coredump(signr)) {
if (print_fatal_signals)
print_fatal_signal(regs, signr);
/* /*
* If it was able to dump core, this kills all * If it was able to dump core, this kills all
* other threads in the group and synchronizes with * other threads in the group and synchronizes with