lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[MMC] Don't check READY_FOR_DATA when reading

Browse Source 
There's no point checking to see if the card is ready to accept
data when we're reading from it - sending the command only wastes
precious bus bandwidth.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
This commit is contained in:
Russell King
2006-09-24 10:46:43 +01:00
committed by Russell King
parent 42431acbac
commit 2ed6d22cec
1 changed files with 19 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
drivers/mmc/mmc_block.c
View File

@@ -231,27 +231,29 @@ static int mmc_blk_issue_rq(struct mmc_queue *mq, struct request *req)
goto cmd_err; goto cmd_err;
} }
do { if (rq_data_dir(req) != READ) {
int err; do {
int err;
cmd.opcode = MMC_SEND_STATUS; cmd.opcode = MMC_SEND_STATUS;
cmd.arg = card->rca << 16; cmd.arg = card->rca << 16;
cmd.flags = MMC_RSP_R1 | MMC_CMD_AC; cmd.flags = MMC_RSP_R1 | MMC_CMD_AC;
err = mmc_wait_for_cmd(card->host, &cmd, 5); err = mmc_wait_for_cmd(card->host, &cmd, 5);
if (err) { if (err) {
printk(KERN_ERR "%s: error %d requesting status\n", printk(KERN_ERR "%s: error %d requesting status\n",
req->rq_disk->disk_name, err); req->rq_disk->disk_name, err);
goto cmd_err; goto cmd_err;
} }
} while (!(cmd.resp[0] & R1_READY_FOR_DATA)); } while (!(cmd.resp[0] & R1_READY_FOR_DATA));
#if 0 #if 0
if (cmd.resp[0] & ~0x00000900) if (cmd.resp[0] & ~0x00000900)
printk(KERN_ERR "%s: status = %08x\n", printk(KERN_ERR "%s: status = %08x\n",
req->rq_disk->disk_name, cmd.resp[0]); req->rq_disk->disk_name, cmd.resp[0]);
if (mmc_decode_status(cmd.resp)) if (mmc_decode_status(cmd.resp))
goto cmd_err; goto cmd_err;
#endif #endif
}
/* /*
* A block was successfully transferred. * A block was successfully transferred.