lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[patch 3/5] vfs: change remove_suid() to file_remove_suid()

Browse Source 
All calls to remove_suid() are made with a file pointer, because
(similarly to file_update_time) it is called when the file is written.

Clean up callers by passing in a file instead of a dentry.

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
This commit is contained in:
Miklos Szeredi
2008-06-24 16:50:14 +02:00
committed by Al Viro
parent c82e42da8a
commit 2f1936b877
7 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
mm/filemap.c
View File

@@ -1758,8 +1758,9 @@ static int __remove_suid(struct dentry *dentry, int kill)
return notify_change(dentry, &newattrs);
}
int remove_suid(struct dentry *dentry)
int file_remove_suid(struct file *file)
{
struct dentry *dentry = file->f_path.dentry;
int killsuid = should_remove_suid(dentry);
int killpriv = security_inode_need_killpriv(dentry);
int error = 0;
@@ -1773,7 +1774,7 @@ int remove_suid(struct dentry *dentry)
return error;
}
EXPORT_SYMBOL(remove_suid);
EXPORT_SYMBOL(file_remove_suid);
static size_t __iovec_copy_from_user_inatomic(char *vaddr,
const struct iovec *iov, size_t base, size_t bytes)
@@ -2529,7 +2530,7 @@ __generic_file_aio_write_nolock(struct kiocb *iocb, const struct iovec *iov,
if (count == 0)
goto out;
err = remove_suid(file->f_path.dentry);
err = file_remove_suid(file);
if (err)
goto out;