lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

pinctrl: abx500: Specify failed sub-driver by ID instead of driver_data

Browse Source 
If a sub-driver has not been specified correctly, there is a good chance
that plat_id is NULL, hence using an attribute of plat_id in the error
message is likely to not only fail the driver but Oops the kernel. Use
the failed ID instead.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Lee Jones
2013-05-08 14:29:07 +01:00
committed by Linus Walleij
parent f722406faa
commit 2fcad12eb4
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/pinctrl/pinctrl-abx500.c
View File

@@ -900,8 +900,7 @@ static int abx500_gpio_probe(struct platform_device *pdev)
abx500_pinctrl_ab8505_init(&pct->soc); abx500_pinctrl_ab8505_init(&pct->soc);
break; break;
default: default:
dev_err(&pdev->dev, "Unsupported pinctrl sub driver (%d)\n", dev_err(&pdev->dev, "Unsupported pinctrl sub driver (%d)\n", id);
(int) platid->driver_data);
mutex_destroy(&pct->lock); mutex_destroy(&pct->lock);
return -EINVAL; return -EINVAL;
} }