lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

leds: Remove incorrect use of preempt_count() from leds-gpio

Browse Source 
It appears that we can't just check to see if we're in a task
context ... so instead of trying that, just make the relevant
leds always schedule a little worklet.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Richard Purdie <rpurdie@rpsys.net>
This commit is contained in:
David Brownell
2008-03-27 00:59:02 +00:00
committed by Richard Purdie
parent d95cbe6158
commit 306dd85c1d
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/leds/leds-gpio.c
View File

@@ -49,13 +49,13 @@ static void gpio_led_set(struct led_classdev *led_cdev,
if (led_dat->active_low) if (led_dat->active_low)
level = !level; level = !level;
/* setting GPIOs with I2C/etc requires a preemptible task context */ /* Setting GPIOs with I2C/etc requires a task context, and we don't
* seem to have a reliable way to know if we're already in one; so
* let's just assume the worst.
*/
if (led_dat->can_sleep) { if (led_dat->can_sleep) {
if (preempt_count()) { led_dat->new_level = level;
led_dat->new_level = level; schedule_work(&led_dat->work);
schedule_work(&led_dat->work);
} else
gpio_set_value_cansleep(led_dat->gpio, level);
} else } else
gpio_set_value(led_dat->gpio, level); gpio_set_value(led_dat->gpio, level);
} }