lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

decnet: Add missing neigh->ha locking to dn_neigh_output_packet()

Browse Source 
Basically, mirror the logic in neigh_connected_output().

Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
David S. Miller
2012-02-01 16:34:25 -05:00
parent f79d52c254
commit 3329bdfc40
1 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
net/decnet/dn_neigh.c
View File

@@ -205,17 +205,23 @@ static int dn_neigh_output_packet(struct sk_buff *skb)
struct neighbour *neigh = dst_get_neighbour_noref(dst); struct neighbour *neigh = dst_get_neighbour_noref(dst);
struct net_device *dev = neigh->dev; struct net_device *dev = neigh->dev;
char mac_addr[ETH_ALEN]; char mac_addr[ETH_ALEN];
unsigned int seq;
int err;
dn_dn2eth(mac_addr, rt->rt_local_src); dn_dn2eth(mac_addr, rt->rt_local_src);
if (dev_hard_header(skb, dev, ntohs(skb->protocol), neigh->ha, do {
mac_addr, skb->len) >= 0) seq = read_seqbegin(&neigh->ha_lock);
return dev_queue_xmit(skb); err = dev_hard_header(skb, dev, ntohs(skb->protocol),
neigh->ha, mac_addr, skb->len);
if (net_ratelimit()) } while (read_seqretry(&neigh->ha_lock, seq));
printk(KERN_DEBUG "dn_neigh_output_packet: oops, can't send packet\n");
if (err >= 0)
err = dev_queue_xmit(skb);
else {
kfree_skb(skb); kfree_skb(skb);
return -EINVAL; err = -EINVAL;
}
return err;
} }
static int dn_long_output(struct neighbour *neigh, struct sk_buff *skb) static int dn_long_output(struct neighbour *neigh, struct sk_buff *skb)