lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

x86: coding style fixes to arch/x86/kernel/cpu/common.c

Browse Source 
Before:
   total: 55 errors, 6 warnings, 727 lines checked
After:
   total: 0 errors, 3 warnings, 734 lines checked

No code changed:

arch/x86/kernel/cpu/common.o:

   text	   data	    bss	    dec	    hex	filename
   3500	   4611	     44	   8155	   1fdb	common.o.before
   3500	   4611	     44	   8155	   1fdb	common.o.after

md5:
   e37091f11fbeb682c0db152ac3022a38  common.o.before.asm
   e37091f11fbeb682c0db152ac3022a38  common.o.after.asm

Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Paolo Ciarrocchi
2008-02-24 11:58:13 +01:00
committed by Ingo Molnar
parent db96598494
commit 34048c9e92
1 changed files with 56 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
arch/x86/kernel/cpu/common.c
View File

@@ -156,9 +156,12 @@ void __cpuinit display_cacheinfo(struct cpuinfo_x86 *c)
l2size, ecx & 0xFF); l2size, ecx & 0xFF);
} }
/* Naming convention should be: <Name> [(<Codename>)] */ /*
/* This table only is used unless init_<vendor>() below doesn't set it; */ * Naming convention should be: <Name> [(<Codename>)]
/* in particular, if CPUID levels 0x80000002..4 are supported, this isn't used */ * This table only is used unless init_<vendor>() below doesn't set it;
* in particular, if CPUID levels 0x80000002..4 are supported, this isn't used
*
*/
/* Look up CPU names by table lookup. */ /* Look up CPU names by table lookup. */
static char __cpuinit *table_lookup_model(struct cpuinfo_x86 *c) static char __cpuinit *table_lookup_model(struct cpuinfo_x86 *c)
@@ -308,12 +311,15 @@ static void __cpuinit early_get_cap(struct cpuinfo_x86 *c)
} }
/* Do minimum CPU detection early. /*
Fields really needed: vendor, cpuid_level, family, model, mask, cache alignment. * Do minimum CPU detection early.
The others are not touched to avoid unwanted side effects. * Fields really needed: vendor, cpuid_level, family, model, mask,
* cache alignment.
WARNING: this function is only called on the BP. Don't add code here * The others are not touched to avoid unwanted side effects.
that is supposed to run on all CPUs. */ *
* WARNING: this function is only called on the BP. Don't add code here
* that is supposed to run on all CPUs.
*/
static void __init early_cpu_detect(void) static void __init early_cpu_detect(void)
{ {
struct cpuinfo_x86 *c = &boot_cpu_data; struct cpuinfo_x86 *c = &boot_cpu_data;
@@ -350,7 +356,6 @@ static void __cpuinit generic_identify(struct cpuinfo_x86 * c)
get_cpu_vendor(c, 0); get_cpu_vendor(c, 0);
/* Initialize the standard set of capabilities */ /* Initialize the standard set of capabilities */
/* Note that the vendor-specific code below might override */ /* Note that the vendor-specific code below might override */
/* Intel-defined flags: level 0x00000001 */ /* Intel-defined flags: level 0x00000001 */
if (c->cpuid_level >= 0x00000001) { if (c->cpuid_level >= 0x00000001) {
u32 capability, excap; u32 capability, excap;
@@ -439,8 +444,10 @@ void __cpuinit identify_cpu(struct cpuinfo_x86 *c)
memset(&c->x86_capability, 0, sizeof c->x86_capability); memset(&c->x86_capability, 0, sizeof c->x86_capability);
if (!have_cpuid_p()) { if (!have_cpuid_p()) {
/* First of all, decide if this is a 486 or higher */ /*
/* It's a 486 if we can modify the AC flag */ * First of all, decide if this is a 486 or higher
* It's a 486 if we can modify the AC flag
*/
if (flag_is_changeable_p(X86_EFLAGS_AC)) if (flag_is_changeable_p(X86_EFLAGS_AC))
c->x86 = 4; c->x86 = 4;
else else