lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

NFSv4: Remove bogus call to nfs4_drop_state_owner() in _nfs4_open_expired()

Browse Source 
There should be no need to invalidate a perfectly good state owner just
because of a stale filehandle. Doing so can cause the state recovery code
to break, since nfs4_get_renew_cred() and nfs4_get_setclientid_cred() rely
on finding active state owners.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
This commit is contained in:
Trond Myklebust
2008-04-05 15:54:17 -04:00
parent dbae4c73f0
commit 35d05778e2
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
fs/nfs/nfs4proc.c
View File

@@ -982,11 +982,8 @@ static int _nfs4_open_expired(struct nfs_open_context *ctx, struct nfs4_state *s
if (IS_ERR(opendata)) if (IS_ERR(opendata))
return PTR_ERR(opendata); return PTR_ERR(opendata);
ret = nfs4_open_recover(opendata, state); ret = nfs4_open_recover(opendata, state);
if (ret == -ESTALE) { if (ret == -ESTALE)
/* Invalidate the state owner so we don't ever use it again */
nfs4_drop_state_owner(state->owner);
d_drop(ctx->path.dentry); d_drop(ctx->path.dentry);
}
nfs4_opendata_put(opendata); nfs4_opendata_put(opendata);
return ret; return ret;
} }