lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[ARM] S3C24XX: GPIO: Fix error returns from gpio functions

Browse Source 
Several GPIO functions have been returning -1 to indicate
an error instead of returning a proper error code. Change
to return -EINVAL for invalid argument(s).

Signed-off-by: Ben Dooks <ben-linux@fluff.org>
This commit is contained in:
Ben Dooks
2009-05-18 19:40:18 +01:00
parent 070276d5d0
commit 373e9644c5
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
arch/arm/mach-s3c2400/gpio.c
View File

@@ -33,8 +33,8 @@
int s3c2400_gpio_getirq(unsigned int pin) int s3c2400_gpio_getirq(unsigned int pin)
{ {
if (pin < S3C2410_GPE(0) || pin > S3C2400_GPE7_EINT7) if (pin < S3C2410_GPE(0) || pin > S3C2400_GPE(7))
return -1; /* not valid interrupts */ return -EINVAL; /* not valid interrupts */
return (pin - S3C2410_GPE(0)) + IRQ_EINT0; return (pin - S3C2410_GPE(0)) + IRQ_EINT0;
} }

2
arch/arm/mach-s3c2410/gpio.c
View File

@@ -40,7 +40,7 @@ int s3c2410_gpio_irqfilter(unsigned int pin, unsigned int on,
unsigned long val; unsigned long val;
if (pin < S3C2410_GPG(8) || pin > S3C2410_GPG(15)) if (pin < S3C2410_GPG(8) || pin > S3C2410_GPG(15))
return -1; return -EINVAL;
config &= 0xff; config &= 0xff;

4
arch/arm/plat-s3c24xx/gpio.c
View File

@@ -184,10 +184,10 @@ EXPORT_SYMBOL(s3c2410_modify_misccr);
int s3c2410_gpio_getirq(unsigned int pin) int s3c2410_gpio_getirq(unsigned int pin)
{ {
if (pin < S3C2410_GPF(0) || pin > S3C2410_GPG(15)) if (pin < S3C2410_GPF(0) || pin > S3C2410_GPG(15))
return -1; /* not valid interrupts */ return -EINVAL; /* not valid interrupts */
if (pin < S3C2410_GPG(0) && pin > S3C2410_GPF(7)) if (pin < S3C2410_GPG(0) && pin > S3C2410_GPF(7))
return -1; /* not valid pin */ return -EINVAL; /* not valid pin */
if (pin < S3C2410_GPF(4)) if (pin < S3C2410_GPF(4))
return (pin - S3C2410_GPF(0)) + IRQ_EINT0; return (pin - S3C2410_GPF(0)) + IRQ_EINT0;