lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

libertas: correct "limited range of data type" warning

Browse Source 
CC [M]  drivers/net/wireless/libertas/wext.o
drivers/net/wireless/libertas/wext.c: In function ‘lbs_get_rts’:
drivers/net/wireless/libertas/wext.c:307: warning: comparison is always
false due to limited range of data type

Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
John W. Linville
2008-09-15 17:25:54 -04:00
parent 75d31cf19f
commit 375da53b8e
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/wireless/libertas/wext.c
View File

@@ -281,7 +281,7 @@ static int lbs_set_rts(struct net_device *dev, struct iw_request_info *info,
if (vwrq->disabled) if (vwrq->disabled)
val = MRVDRV_RTS_MAX_VALUE; val = MRVDRV_RTS_MAX_VALUE;
if (val < MRVDRV_RTS_MIN_VALUE || val > MRVDRV_RTS_MAX_VALUE) if (val > MRVDRV_RTS_MAX_VALUE) /* min rts value is 0 */
return -EINVAL; return -EINVAL;
ret = lbs_set_snmp_mib(priv, SNMP_MIB_OID_RTS_THRESHOLD, (u16) val); ret = lbs_set_snmp_mib(priv, SNMP_MIB_OID_RTS_THRESHOLD, (u16) val);
@@ -304,8 +304,7 @@ static int lbs_get_rts(struct net_device *dev, struct iw_request_info *info,
goto out; goto out;
vwrq->value = val; vwrq->value = val;
vwrq->disabled = ((val < MRVDRV_RTS_MIN_VALUE) vwrq->disabled = val > MRVDRV_RTS_MAX_VALUE; /* min rts value is 0 */
|| (val > MRVDRV_RTS_MAX_VALUE));
vwrq->fixed = 1; vwrq->fixed = 1;
out: out: