lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

sound: oss/sb_audio: cap value in sb201_audio_set_speed()

Browse Source 
We set "s" before we have capped "speed" so it could be the wrong value.
This could lead to a divide by zero bug.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Dan Carpenter
2012-11-17 18:08:57 +03:00
committed by Takashi Iwai
parent 190006f9d6
commit 379170a42c
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
sound/oss/sb_audio.c
View File

@@ -442,7 +442,7 @@ static int sb201_audio_set_speed(int dev, int speed)
{ {
sb_devc *devc = audio_devs[dev]->devc; sb_devc *devc = audio_devs[dev]->devc;
int tmp; int tmp;
int s = speed * devc->channels; int s;
if (speed > 0) if (speed > 0)
{ {
@@ -452,6 +452,7 @@ static int sb201_audio_set_speed(int dev, int speed)
speed = 44100; speed = 44100;
if (devc->opened & OPEN_READ && speed > 15000) if (devc->opened & OPEN_READ && speed > 15000)
speed = 15000; speed = 15000;
s = speed * devc->channels;
devc->tconst = (256 - ((1000000 + s / 2) / s)) & 0xff; devc->tconst = (256 - ((1000000 + s / 2) / s)) & 0xff;
tmp = 256 - devc->tconst; tmp = 256 - devc->tconst;
speed = ((1000000 + tmp / 2) / tmp) / devc->channels; speed = ((1000000 + tmp / 2) / tmp) / devc->channels;