lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

macvtap: zerocopy: fix offset calculation when building skb

Browse Source 
This patch fixes the offset calculation when building skb:

- offset1 were used as skb data offset not vector offset
- reset offset to zero only when we advance to next vector

Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Jason Wang
2012-05-02 11:41:30 +08:00
committed by Michael S. Tsirkin
parent 64d098886e
commit 3afc9621f1
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/net/macvtap.c
View File

@@ -505,10 +505,11 @@ static int zerocopy_sg_from_iovec(struct sk_buff *skb, const struct iovec *from,
if (copy > size) { if (copy > size) {
++from; ++from;
--count; --count;
} offset = 0;
} else
offset += size;
copy -= size; copy -= size;
offset1 += size; offset1 += size;
offset = 0;
} }
if (len == offset1) if (len == offset1)
@@ -519,13 +520,13 @@ static int zerocopy_sg_from_iovec(struct sk_buff *skb, const struct iovec *from,
int num_pages; int num_pages;
unsigned long base; unsigned long base;
len = from->iov_len - offset1; len = from->iov_len - offset;
if (!len) { if (!len) {
offset1 = 0; offset = 0;
++from; ++from;
continue; continue;
} }
base = (unsigned long)from->iov_base + offset1; base = (unsigned long)from->iov_base + offset;
size = ((base & ~PAGE_MASK) + len + ~PAGE_MASK) >> PAGE_SHIFT; size = ((base & ~PAGE_MASK) + len + ~PAGE_MASK) >> PAGE_SHIFT;
num_pages = get_user_pages_fast(base, size, 0, &page[i]); num_pages = get_user_pages_fast(base, size, 0, &page[i]);
if ((num_pages != size) || if ((num_pages != size) ||
@@ -546,7 +547,7 @@ static int zerocopy_sg_from_iovec(struct sk_buff *skb, const struct iovec *from,
len -= size; len -= size;
i++; i++;
} }
offset1 = 0; offset = 0;
++from; ++from;
} }
return 0; return 0;