lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

act_police: remove unnecessary null pointer check

Browse Source 
It already has a NULL pointer check of rtab in qdisc_put_rtab().
Remove the check outside of qdisc_put_rtab().

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Yang Yingliang
2013-12-17 15:29:16 +08:00
committed by David S. Miller
parent d2adcaa82d
commit 3b69a4c9be
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
net/sched/act_police.c
View File

@@ -261,10 +261,8 @@ override:
failure_unlock: failure_unlock:
spin_unlock_bh(&police->tcf_lock); spin_unlock_bh(&police->tcf_lock);
failure: failure:
if (P_tab) qdisc_put_rtab(P_tab);
qdisc_put_rtab(P_tab); qdisc_put_rtab(R_tab);
if (R_tab)
qdisc_put_rtab(R_tab);
if (ret == ACT_P_CREATED) if (ret == ACT_P_CREATED)
kfree(police); kfree(police);
return err; return err;