lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gpio_free might sleep, generic part

Browse Source 
According to the documentation gpio_free should only be called from task
context only.  To make this more explicit add a might sleep to all
implementations.

This is the generic part which changes gpiolib and the fallback
implementation only.

Signed-off-by: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Uwe Kleine-König
2008-10-15 22:03:12 -07:00
committed by Linus Torvalds
parent c557fa3e4c
commit 3d599d1ca5
2 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpio/gpiolib.c
View File

@@ -792,6 +792,8 @@ void gpio_free(unsigned gpio)
unsigned long flags; unsigned long flags;
struct gpio_desc *desc; struct gpio_desc *desc;
might_sleep();
if (!gpio_is_valid(gpio)) { if (!gpio_is_valid(gpio)) {
WARN_ON(extra_checks); WARN_ON(extra_checks);
return; return;

3
include/linux/gpio.h
View File

@@ -8,6 +8,7 @@
#else #else
#include <linux/kernel.h>
#include <linux/types.h> #include <linux/types.h>
#include <linux/errno.h> #include <linux/errno.h>
@@ -32,6 +33,8 @@ static inline int gpio_request(unsigned gpio, const char *label)
static inline void gpio_free(unsigned gpio) static inline void gpio_free(unsigned gpio)
{ {
might_sleep();
/* GPIO can never have been requested */ /* GPIO can never have been requested */
WARN_ON(1); WARN_ON(1);
} }