lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[SCSI] Fix uninitialized variable error in scsi_io_completion

Browse Source 
This patch (as1191) adds a missing "default" case in
scsi_io_completion(), thereby fixing an "uninitialized variable"
error.  It also adds a missing newline to a log entry.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
This commit is contained in:
Alan Stern
2008-12-15 10:31:28 -05:00
committed by James Bottomley
parent fa9907810b
commit 3dbf6a5404
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/scsi/scsi_lib.c
View File

@@ -1029,6 +1029,10 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes)
case 0x09: /* self test in progress */ case 0x09: /* self test in progress */
action = ACTION_DELAYED_RETRY; action = ACTION_DELAYED_RETRY;
break; break;
default:
description = "Device not ready";
action = ACTION_FAIL;
break;
} }
} else { } else {
description = "Device not ready"; description = "Device not ready";
@@ -1054,7 +1058,7 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes)
/* Give up and fail the remainder of the request */ /* Give up and fail the remainder of the request */
if (!(req->cmd_flags & REQ_QUIET)) { if (!(req->cmd_flags & REQ_QUIET)) {
if (description) if (description)
scmd_printk(KERN_INFO, cmd, "%s", scmd_printk(KERN_INFO, cmd, "%s\n",
description); description);
scsi_print_result(cmd); scsi_print_result(cmd);
if (driver_byte(result) & DRIVER_SENSE) if (driver_byte(result) & DRIVER_SENSE)