lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

firewire: cdev: address handler input validation

Browse Source 
Like before my commit 1415d9189e,
fw_core_add_address_handler() does not align the address region now.
Instead the caller is required to pass valid parameters.

Since one of the callers of fw_core_add_address_handler() is the cdev
userspace interface, we now check for valid input.  If the client is
buggy, we give it a hint with -EINVAL.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
This commit is contained in:
Stefan Richter
2008-12-14 19:21:01 +01:00
parent 45ee3199eb
commit 3e0b5f0d7c
2 changed files with 21 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/firewire/fw-cdev.c
View File

@@ -591,9 +591,10 @@ static int ioctl_allocate(struct client *client, void *buffer)
handler->closure = request->closure;
handler->client = client;
if (fw_core_add_address_handler(&handler->handler, &region) < 0) {
ret = fw_core_add_address_handler(&handler->handler, &region);
if (ret < 0) {
kfree(handler);
return -EBUSY;
return ret;
}
handler->resource.release = release_address_handler;