lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Input: drivers/input/touchscreen - don't access dev->private directly

Browse Source 
Use input_get_drvdata() and input_set_drvdata() instead.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
This commit is contained in:
Dmitry Torokhov
2007-04-12 01:34:08 -04:00
parent 0ca1804f2e
commit 40b9b0b82e
9 changed files with 8 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/input/touchscreen/corgi_ts.c
View File

@@ -301,7 +301,6 @@ static int __init corgits_probe(struct platform_device *pdev)
input_dev->id.product = 0x0002; input_dev->id.product = 0x0002;
input_dev->id.version = 0x0100; input_dev->id.version = 0x0100;
input_dev->cdev.dev = &pdev->dev; input_dev->cdev.dev = &pdev->dev;
input_dev->private = corgi_ts;
input_dev->evbit[0] = BIT(EV_KEY) | BIT(EV_ABS); input_dev->evbit[0] = BIT(EV_KEY) | BIT(EV_ABS);
input_dev->keybit[LONG(BTN_TOUCH)] = BIT(BTN_TOUCH); input_dev->keybit[LONG(BTN_TOUCH)] = BIT(BTN_TOUCH);

1
drivers/input/touchscreen/elo.c
View File

@@ -312,7 +312,6 @@ static int elo_connect(struct serio *serio, struct serio_driver *drv)
init_completion(&elo->cmd_done); init_completion(&elo->cmd_done);
snprintf(elo->phys, sizeof(elo->phys), "%s/input0", serio->phys); snprintf(elo->phys, sizeof(elo->phys), "%s/input0", serio->phys);
input_dev->private = elo;
input_dev->name = "Elo Serial TouchScreen"; input_dev->name = "Elo Serial TouchScreen";
input_dev->phys = elo->phys; input_dev->phys = elo->phys;
input_dev->id.bustype = BUS_RS232; input_dev->id.bustype = BUS_RS232;

1
drivers/input/touchscreen/gunze.c
View File

@@ -130,7 +130,6 @@ static int gunze_connect(struct serio *serio, struct serio_driver *drv)
gunze->dev = input_dev; gunze->dev = input_dev;
snprintf(gunze->phys, sizeof(serio->phys), "%s/input0", serio->phys); snprintf(gunze->phys, sizeof(serio->phys), "%s/input0", serio->phys);
input_dev->private = gunze;
input_dev->name = "Gunze AHL-51S TouchScreen"; input_dev->name = "Gunze AHL-51S TouchScreen";
input_dev->phys = gunze->phys; input_dev->phys = gunze->phys;
input_dev->id.bustype = BUS_RS232; input_dev->id.bustype = BUS_RS232;

7
drivers/input/touchscreen/h3600_ts_input.c
View File

@@ -147,7 +147,7 @@ enum flite_pwr {
unsigned int h3600_flite_power(struct input_dev *dev, enum flite_pwr pwr) unsigned int h3600_flite_power(struct input_dev *dev, enum flite_pwr pwr)
{ {
unsigned char brightness = (pwr == FLITE_PWR_OFF) ? 0 : flite_brightness; unsigned char brightness = (pwr == FLITE_PWR_OFF) ? 0 : flite_brightness;
struct h3600_dev *ts = dev->private; struct h3600_dev *ts = input_get_drvdata(dev);
/* Must be in this order */ /* Must be in this order */
ts->serio->write(ts->serio, 1); ts->serio->write(ts->serio, 1);
@@ -260,7 +260,7 @@ static int h3600ts_event(struct input_dev *dev, unsigned int type,
unsigned int code, int value) unsigned int code, int value)
{ {
#if 0 #if 0
struct h3600_dev *ts = dev->private; struct h3600_dev *ts = input_get_drvdata(dev);
switch (type) { switch (type) {
case EV_LED: { case EV_LED: {
@@ -368,7 +368,8 @@ static int h3600ts_connect(struct serio *serio, struct serio_driver *drv)
input_dev->id.product = 0x0666; /* FIXME !!! We can ask the hardware */ input_dev->id.product = 0x0666; /* FIXME !!! We can ask the hardware */
input_dev->id.version = 0x0100; input_dev->id.version = 0x0100;
input_dev->cdev.dev = &serio->dev; input_dev->cdev.dev = &serio->dev;
input_dev->private = ts;
input_set_drvdata(input_dev, ts);
input_dev->event = h3600ts_event; input_dev->event = h3600ts_event;

1
drivers/input/touchscreen/mtouch.c
View File

@@ -144,7 +144,6 @@ static int mtouch_connect(struct serio *serio, struct serio_driver *drv)
mtouch->dev = input_dev; mtouch->dev = input_dev;
snprintf(mtouch->phys, sizeof(mtouch->phys), "%s/input0", serio->phys); snprintf(mtouch->phys, sizeof(mtouch->phys), "%s/input0", serio->phys);
input_dev->private = mtouch;
input_dev->name = "MicroTouch Serial TouchScreen"; input_dev->name = "MicroTouch Serial TouchScreen";
input_dev->phys = mtouch->phys; input_dev->phys = mtouch->phys;
input_dev->id.bustype = BUS_RS232; input_dev->id.bustype = BUS_RS232;

1
drivers/input/touchscreen/penmount.c
View File

@@ -105,7 +105,6 @@ static int pm_connect(struct serio *serio, struct serio_driver *drv)
pm->dev = input_dev; pm->dev = input_dev;
snprintf(pm->phys, sizeof(pm->phys), "%s/input0", serio->phys); snprintf(pm->phys, sizeof(pm->phys), "%s/input0", serio->phys);
input_dev->private = pm;
input_dev->name = "Penmount Serial TouchScreen"; input_dev->name = "Penmount Serial TouchScreen";
input_dev->phys = pm->phys; input_dev->phys = pm->phys;
input_dev->id.bustype = BUS_RS232; input_dev->id.bustype = BUS_RS232;

1
drivers/input/touchscreen/touchright.c
View File

@@ -118,7 +118,6 @@ static int tr_connect(struct serio *serio, struct serio_driver *drv)
tr->dev = input_dev; tr->dev = input_dev;
snprintf(tr->phys, sizeof(tr->phys), "%s/input0", serio->phys); snprintf(tr->phys, sizeof(tr->phys), "%s/input0", serio->phys);
input_dev->private = tr;
input_dev->name = "Touchright Serial TouchScreen"; input_dev->name = "Touchright Serial TouchScreen";
input_dev->phys = tr->phys; input_dev->phys = tr->phys;
input_dev->id.bustype = BUS_RS232; input_dev->id.bustype = BUS_RS232;

1
drivers/input/touchscreen/touchwin.c
View File

@@ -125,7 +125,6 @@ static int tw_connect(struct serio *serio, struct serio_driver *drv)
tw->dev = input_dev; tw->dev = input_dev;
snprintf(tw->phys, sizeof(tw->phys), "%s/input0", serio->phys); snprintf(tw->phys, sizeof(tw->phys), "%s/input0", serio->phys);
input_dev->private = tw;
input_dev->name = "Touchwindow Serial TouchScreen"; input_dev->name = "Touchwindow Serial TouchScreen";
input_dev->phys = tw->phys; input_dev->phys = tw->phys;
input_dev->id.bustype = BUS_RS232; input_dev->id.bustype = BUS_RS232;

7
drivers/input/touchscreen/ucb1400_ts.c
View File

@@ -369,7 +369,7 @@ static irqreturn_t ucb1400_hard_irq(int irqnr, void *devid)
static int ucb1400_ts_open(struct input_dev *idev) static int ucb1400_ts_open(struct input_dev *idev)
{ {
struct ucb1400 *ucb = idev->private; struct ucb1400 *ucb = input_get_drvdata(idev);
int ret = 0; int ret = 0;
BUG_ON(ucb->ts_task); BUG_ON(ucb->ts_task);
@@ -385,7 +385,7 @@ static int ucb1400_ts_open(struct input_dev *idev)
static void ucb1400_ts_close(struct input_dev *idev) static void ucb1400_ts_close(struct input_dev *idev)
{ {
struct ucb1400 *ucb = idev->private; struct ucb1400 *ucb = input_get_drvdata(idev);
if (ucb->ts_task) if (ucb->ts_task)
kthread_stop(ucb->ts_task); kthread_stop(ucb->ts_task);
@@ -507,7 +507,8 @@ static int ucb1400_ts_probe(struct device *dev)
} }
printk(KERN_DEBUG "UCB1400: found IRQ %d\n", ucb->irq); printk(KERN_DEBUG "UCB1400: found IRQ %d\n", ucb->irq);
idev->private = ucb; input_set_drvdata(idev, ucb);
idev->cdev.dev = dev; idev->cdev.dev = dev;
idev->name = "UCB1400 touchscreen interface"; idev->name = "UCB1400 touchscreen interface";
idev->id.vendor = ucb1400_reg_read(ucb, AC97_VENDOR_ID1); idev->id.vendor = ucb1400_reg_read(ucb, AC97_VENDOR_ID1);