lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

PCI: pcie portdrv: style cleanup

Browse Source 
No change in logic.

Before:
  drivers/pci/pcie/portdrv_core.c:
    total: 7 errors, 2 warnings, 508 lines checked
  drivers/pci/pcie/portdrv_pci.c:
    total: 4 errors, 2 warnings, 300 lines checked

After:
  drivers/pci/pcie/portdrv_core.c:
    total: 0 errors, 0 warnings, 506 lines checked
  drivers/pci/pcie/portdrv_pci.c:
    total: 0 errors, 0 warnings, 299 lines checked

Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
This commit is contained in:
Hidetoshi Seto
2009-12-15 11:38:04 +09:00
committed by Jesse Barnes
parent 45d28b0972
commit 40da4186a5
2 changed files with 15 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/pci/pcie/portdrv_core.c
View File

@@ -346,8 +346,7 @@ static int suspend_iter(struct device *dev, void *data)
{ {
struct pcie_port_service_driver *service_driver; struct pcie_port_service_driver *service_driver;
if ((dev->bus == &pcie_port_bus_type) && if ((dev->bus == &pcie_port_bus_type) && dev->driver) {
(dev->driver)) {
service_driver = to_service_driver(dev->driver); service_driver = to_service_driver(dev->driver);
if (service_driver->suspend) if (service_driver->suspend)
service_driver->suspend(to_pcie_device(dev)); service_driver->suspend(to_pcie_device(dev));
@@ -494,6 +493,7 @@ int pcie_port_service_register(struct pcie_port_service_driver *new)
return driver_register(&new->driver); return driver_register(&new->driver);
} }
EXPORT_SYMBOL(pcie_port_service_register);
/** /**
* pcie_port_service_unregister - unregister PCI Express port service driver * pcie_port_service_unregister - unregister PCI Express port service driver
@@ -503,6 +503,4 @@ void pcie_port_service_unregister(struct pcie_port_service_driver *drv)
{ {
driver_unregister(&drv->driver); driver_unregister(&drv->driver);
} }
EXPORT_SYMBOL(pcie_port_service_register);
EXPORT_SYMBOL(pcie_port_service_unregister); EXPORT_SYMBOL(pcie_port_service_unregister);

11
drivers/pci/pcie/portdrv_pci.c
View File

@@ -91,7 +91,7 @@ static int __devinit pcie_portdrv_probe(struct pci_dev *dev,
return 0; return 0;
} }
static void pcie_portdrv_remove (struct pci_dev *dev) static void pcie_portdrv_remove(struct pci_dev *dev)
{ {
pcie_port_device_remove(dev); pcie_port_device_remove(dev);
pci_disable_device(dev); pci_disable_device(dev);
@@ -129,14 +129,13 @@ static int error_detected_iter(struct device *device, void *data)
static pci_ers_result_t pcie_portdrv_error_detected(struct pci_dev *dev, static pci_ers_result_t pcie_portdrv_error_detected(struct pci_dev *dev,
enum pci_channel_state error) enum pci_channel_state error)
{ {
struct aer_broadcast_data result_data = struct aer_broadcast_data data = {error, PCI_ERS_RESULT_CAN_RECOVER};
{error, PCI_ERS_RESULT_CAN_RECOVER}; int ret;
int retval;
/* can not fail */ /* can not fail */
retval = device_for_each_child(&dev->dev, &result_data, error_detected_iter); ret = device_for_each_child(&dev->dev, &data, error_detected_iter);
return result_data.result; return data.result;
} }
static int mmio_enabled_iter(struct device *device, void *data) static int mmio_enabled_iter(struct device *device, void *data)