lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

USB: sisusbvga: Remove the BKL from ioctl

Browse Source 
Seems to me that BKL is not needed here because necessary locking is already
provided by mutex sisusb->lock.

Also change the returned value to long.

Signed-off-by: Alessio Igor Bogani <abogani@texware.it>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Alessio Igor Bogani
2010-03-01 14:10:56 +01:00
committed by Greg Kroah-Hartman
parent d20db4b4e9
commit 41f2c6e89c
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/misc/sisusbvga/sisusb.c
View File

@@ -2974,13 +2974,12 @@ sisusb_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
struct sisusb_usb_data *sisusb; struct sisusb_usb_data *sisusb;
struct sisusb_info x; struct sisusb_info x;
struct sisusb_command y; struct sisusb_command y;
int retval = 0; long retval = 0;
u32 __user *argp = (u32 __user *)arg; u32 __user *argp = (u32 __user *)arg;
if (!(sisusb = (struct sisusb_usb_data *)file->private_data)) if (!(sisusb = (struct sisusb_usb_data *)file->private_data))
return -ENODEV; return -ENODEV;
lock_kernel();
mutex_lock(&sisusb->lock); mutex_lock(&sisusb->lock);
/* Sanity check */ /* Sanity check */
@@ -3039,7 +3038,6 @@ sisusb_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
err_out: err_out:
mutex_unlock(&sisusb->lock); mutex_unlock(&sisusb->lock);
unlock_kernel();
return retval; return retval;
} }