[PATCH] mm: rss = file_rss + anon_rss
I was lazy when we added anon_rss, and chose to change as few places as possible. So currently each anonymous page has to be counted twice, in rss and in anon_rss. Which won't be so good if those are atomic counts in some configurations. Change that around: keep file_rss and anon_rss separately, and add them together (with get_mm_rss macro) when the total is needed - reading two atomics is much cheaper than updating two atomics. And update anon_rss upfront, typically in memory.c, not tucked away in page_add_anon_rmap. Signed-off-by: Hugh Dickins <hugh@veritas.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
committed by
Linus Torvalds
parent
404351e67a
commit
4294621f41
@ -321,7 +321,7 @@ static struct mm_struct * mm_init(struct mm_struct * mm)
|
||||
INIT_LIST_HEAD(&mm->mmlist);
|
||||
mm->core_waiters = 0;
|
||||
mm->nr_ptes = 0;
|
||||
set_mm_counter(mm, rss, 0);
|
||||
set_mm_counter(mm, file_rss, 0);
|
||||
set_mm_counter(mm, anon_rss, 0);
|
||||
spin_lock_init(&mm->page_table_lock);
|
||||
rwlock_init(&mm->ioctx_list_lock);
|
||||
@ -499,7 +499,7 @@ static int copy_mm(unsigned long clone_flags, struct task_struct * tsk)
|
||||
if (retval)
|
||||
goto free_pt;
|
||||
|
||||
mm->hiwater_rss = get_mm_counter(mm,rss);
|
||||
mm->hiwater_rss = get_mm_rss(mm);
|
||||
mm->hiwater_vm = mm->total_vm;
|
||||
|
||||
good_mm:
|
||||
|
Reference in New Issue
Block a user