[PATCH] uml: some harmless sparse warning fixes
Fix some simple sparse warnings - a lot more staticness and a misplaced __user. Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> Cc: Jeff Dike <jdike@addtoit.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
committed by
Linus Torvalds
parent
4cd7ed9442
commit
42947cb98f
@@ -327,7 +327,7 @@ void mconsole_stop(struct mc_request *req)
|
||||
|
||||
/* This list is populated by __initcall routines. */
|
||||
|
||||
LIST_HEAD(mconsole_devices);
|
||||
static LIST_HEAD(mconsole_devices);
|
||||
|
||||
void mconsole_register_dev(struct mc_device *new)
|
||||
{
|
||||
@@ -561,6 +561,8 @@ void mconsole_sysrq(struct mc_request *req)
|
||||
}
|
||||
#endif
|
||||
|
||||
#ifdef CONFIG_MODE_SKAS
|
||||
|
||||
static void stack_proc(void *arg)
|
||||
{
|
||||
struct task_struct *from = current, *to = arg;
|
||||
@@ -574,7 +576,7 @@ static void stack_proc(void *arg)
|
||||
* Dumps a stacks registers to the linux console.
|
||||
* Usage stack <pid>.
|
||||
*/
|
||||
void do_stack(struct mc_request *req)
|
||||
static void do_stack_trace(struct mc_request *req)
|
||||
{
|
||||
char *ptr = req->request.data;
|
||||
int pid_requested= -1;
|
||||
@@ -605,6 +607,7 @@ void do_stack(struct mc_request *req)
|
||||
}
|
||||
with_console(req, stack_proc, to);
|
||||
}
|
||||
#endif /* CONFIG_MODE_SKAS */
|
||||
|
||||
void mconsole_stack(struct mc_request *req)
|
||||
{
|
||||
@@ -613,7 +616,7 @@ void mconsole_stack(struct mc_request *req)
|
||||
*/
|
||||
CHOOSE_MODE(mconsole_reply(req, "Sorry, this doesn't work in TT mode",
|
||||
1, 0),
|
||||
do_stack(req));
|
||||
do_stack_trace(req));
|
||||
}
|
||||
|
||||
/* Changed by mconsole_setup, which is __setup, and called before SMP is
|
||||
|
Reference in New Issue
Block a user