lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

drivers/net/wireless/libertas: move a dereference below a NULL test

Browse Source 
In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.  I have also taken advantage of the availability
of the value of priv->dev in the subsequent calls to netif_stop_queue and
netif_carrier_off.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Julia Lawall
2009-01-09 10:23:10 +00:00
committed by David S. Miller
parent 0397a26484
commit 43baa5bb26
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/net/wireless/libertas/main.c
View File

@@ -1369,7 +1369,7 @@ EXPORT_SYMBOL_GPL(lbs_start_card);
void lbs_stop_card(struct lbs_private *priv) void lbs_stop_card(struct lbs_private *priv)
{ {
struct net_device *dev = priv->dev; struct net_device *dev;
struct cmd_ctrl_node *cmdnode; struct cmd_ctrl_node *cmdnode;
unsigned long flags; unsigned long flags;
@@ -1377,9 +1377,10 @@ void lbs_stop_card(struct lbs_private *priv)
if (!priv) if (!priv)
goto out; goto out;
dev = priv->dev;
netif_stop_queue(priv->dev); netif_stop_queue(dev);
netif_carrier_off(priv->dev); netif_carrier_off(dev);
lbs_debugfs_remove_one(priv); lbs_debugfs_remove_one(priv);
if (priv->mesh_tlv) { if (priv->mesh_tlv) {