lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[SCSI] Buslogic: local_irq_disable() is redundant after local_irq_save()

Browse Source 
drivers/scsi/BusLogic.c::BusLogic_Command() contains local_irq_disable() call
after local_irq_save().  This looks redundant.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
This commit is contained in:
Jiri Kosina
2007-02-01 16:43:07 -08:00
committed by James Bottomley
parent 083d1631be
commit 4474643897
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/scsi/BusLogic.c
View File

@ -362,10 +362,8 @@ static int BusLogic_Command(struct BusLogic_HostAdapter *HostAdapter, enum BusLo
interrupt could occur if the IRQ Channel was previously enabled by another interrupt could occur if the IRQ Channel was previously enabled by another
BusLogic Host Adapter or another driver sharing the same IRQ Channel. BusLogic Host Adapter or another driver sharing the same IRQ Channel.
*/ */
if (!HostAdapter->IRQ_ChannelAcquired) { if (!HostAdapter->IRQ_ChannelAcquired)
local_irq_save(ProcessorFlags); local_irq_save(ProcessorFlags);
local_irq_disable();
}
/* /*
Wait for the Host Adapter Ready bit to be set and the Command/Parameter Wait for the Host Adapter Ready bit to be set and the Command/Parameter
Register Busy bit to be reset in the Status Register. Register Busy bit to be reset in the Status Register.