cgroup: notify ns_cgroup deprecated
The ns_cgroup will be removed very soon. Let's warn, for this version, ns_cgroup is deprecated. Make ns_cgroup and clone_children exclusive. If the clone_children is set and the ns_cgroup is mounted, let's fail with EINVAL when the ns_cgroup subsys is created (a printk will help the user to understand why the creation fails). Update the feature remove schedule file with the deprecated ns_cgroup. Signed-off-by: Daniel Lezcano <daniel.lezcano@free.fr> Acked-by: Paul Menage <menage@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
committed by
Linus Torvalds
parent
f4a2589fea
commit
45531757b4
@@ -85,6 +85,14 @@ static struct cgroup_subsys_state *ns_create(struct cgroup_subsys *ss,
|
||||
return ERR_PTR(-EPERM);
|
||||
if (!cgroup_is_descendant(cgroup, current))
|
||||
return ERR_PTR(-EPERM);
|
||||
if (test_bit(CGRP_CLONE_CHILDREN, &cgroup->flags)) {
|
||||
printk("ns_cgroup can't be created with parent "
|
||||
"'clone_children' set.\n");
|
||||
return ERR_PTR(-EINVAL);
|
||||
}
|
||||
|
||||
printk_once("ns_cgroup deprecated: consider using the "
|
||||
"'clone_children' flag without the ns_cgroup.\n");
|
||||
|
||||
ns_cgroup = kzalloc(sizeof(*ns_cgroup), GFP_KERNEL);
|
||||
if (!ns_cgroup)
|
||||
|
Reference in New Issue
Block a user