lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

NFS: Change sign of some loop indices in nfs4xdr.c

Browse Source 
Nit: Eliminate some mixed sign comparisons in loop indices.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
This commit is contained in:
Chuck Lever
2007-10-26 13:32:08 -04:00
committed by Trond Myklebust
parent bcecff77a9
commit 464ad6b1ad
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
fs/nfs/nfs4xdr.c
View File

@@ -2515,14 +2515,12 @@ static int decode_attr_files_total(struct xdr_stream *xdr, uint32_t *bitmap, uin
static int decode_pathname(struct xdr_stream *xdr, struct nfs4_pathname *path) static int decode_pathname(struct xdr_stream *xdr, struct nfs4_pathname *path)
{ {
int n; u32 n;
__be32 *p; __be32 *p;
int status = 0; int status = 0;
READ_BUF(4); READ_BUF(4);
READ32(n); READ32(n);
if (n < 0)
goto out_eio;
if (n == 0) if (n == 0)
goto root_path; goto root_path;
dprintk("path "); dprintk("path ");
@@ -2579,13 +2577,11 @@ static int decode_attr_fs_locations(struct xdr_stream *xdr, uint32_t *bitmap, st
goto out_eio; goto out_eio;
res->nlocations = 0; res->nlocations = 0;
while (res->nlocations < n) { while (res->nlocations < n) {
int m; u32 m;
struct nfs4_fs_location *loc = &res->locations[res->nlocations]; struct nfs4_fs_location *loc = &res->locations[res->nlocations];
READ_BUF(4); READ_BUF(4);
READ32(m); READ32(m);
if (m <= 0)
goto out_eio;
loc->nservers = 0; loc->nservers = 0;
dprintk("%s: servers ", __FUNCTION__); dprintk("%s: servers ", __FUNCTION__);
@@ -2598,8 +2594,12 @@ static int decode_attr_fs_locations(struct xdr_stream *xdr, uint32_t *bitmap, st
if (loc->nservers < NFS4_FS_LOCATION_MAXSERVERS) if (loc->nservers < NFS4_FS_LOCATION_MAXSERVERS)
loc->nservers++; loc->nservers++;
else { else {
int i; unsigned int i;
dprintk("%s: using first %d of %d servers returned for location %d\n", __FUNCTION__, NFS4_FS_LOCATION_MAXSERVERS, m, res->nlocations); dprintk("%s: using first %u of %u servers "
"returned for location %u\n",
__FUNCTION__,
NFS4_FS_LOCATION_MAXSERVERS,
m, res->nlocations);
for (i = loc->nservers; i < m; i++) { for (i = loc->nservers; i < m; i++) {
unsigned int len; unsigned int len;
char *data; char *data;