lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

USB: misc/adutux, fix lock imbalance

Browse Source 
Don't unlock adutux_mutex when not held.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Jiri Slaby
2009-03-11 21:47:38 +01:00
committed by Greg Kroah-Hartman
parent 909b6c3fc2
commit 46c9844c40
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/usb/misc/adutux.c
View File

@@ -376,7 +376,7 @@ static int adu_release(struct inode *inode, struct file *file)
if (dev->open_count <= 0) { if (dev->open_count <= 0) {
dbg(1," %s : device not opened", __func__); dbg(1," %s : device not opened", __func__);
retval = -ENODEV; retval = -ENODEV;
goto exit; goto unlock;
} }
adu_release_internal(dev); adu_release_internal(dev);
@@ -385,9 +385,9 @@ static int adu_release(struct inode *inode, struct file *file)
if (!dev->open_count) /* ... and we're the last user */ if (!dev->open_count) /* ... and we're the last user */
adu_delete(dev); adu_delete(dev);
} }
unlock:
exit:
mutex_unlock(&adutux_mutex); mutex_unlock(&adutux_mutex);
exit:
dbg(2," %s : leave, return value %d", __func__, retval); dbg(2," %s : leave, return value %d", __func__, retval);
return retval; return retval;
} }