[PATCH] USB: fix hid core to return proper error code from probe
Drivers need to return -ENODEV when they can't bind to a device. Anything else stops the "bind a device to a driver" search. From: Stelian Pop <stelian@popies.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
b7c84c6ada
commit
479f6ea85e
@@ -1762,7 +1762,7 @@ static int hid_probe(struct usb_interface *intf, const struct usb_device_id *id)
|
|||||||
intf->altsetting->desc.bInterfaceNumber);
|
intf->altsetting->desc.bInterfaceNumber);
|
||||||
|
|
||||||
if (!(hid = usb_hid_configure(intf)))
|
if (!(hid = usb_hid_configure(intf)))
|
||||||
return -EIO;
|
return -ENODEV;
|
||||||
|
|
||||||
hid_init_reports(hid);
|
hid_init_reports(hid);
|
||||||
hid_dump_device(hid);
|
hid_dump_device(hid);
|
||||||
@@ -1777,7 +1777,7 @@ static int hid_probe(struct usb_interface *intf, const struct usb_device_id *id)
|
|||||||
if (!hid->claimed) {
|
if (!hid->claimed) {
|
||||||
printk ("HID device not claimed by input or hiddev\n");
|
printk ("HID device not claimed by input or hiddev\n");
|
||||||
hid_disconnect(intf);
|
hid_disconnect(intf);
|
||||||
return -EIO;
|
return -ENODEV;
|
||||||
}
|
}
|
||||||
|
|
||||||
printk(KERN_INFO);
|
printk(KERN_INFO);
|
||||||
|
Reference in New Issue
Block a user