lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

pkt_sched: remove unnecessary xchg() in packet classifiers

Browse Source 
The use of xchg() hasn't been necessary since 2.2.something when proper
locking was added to packet schedulers. In the case of classifiers they
mostly weren't even necessary before that since they're mainly used
to assign a NULL pointer to the filter root in the ->destroy path;
the root is destroyed immediately after that.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Patrick McHardy
2008-11-19 08:03:09 +00:00
committed by David S. Miller
parent b94c8afcba
commit 47a1a1d4be
7 changed files with 12 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
net/sched/cls_cgroup.c
View File

@ -201,9 +201,7 @@ static int cls_cgroup_change(struct tcf_proto *tp, unsigned long base,
static void cls_cgroup_destroy(struct tcf_proto *tp)
{
struct cls_cgroup_head *head;
head = (struct cls_cgroup_head *)xchg(&tp->root, NULL);
struct cls_cgroup_head *head = tp->root;
if (head) {
tcf_exts_destroy(tp, &head->exts);