lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

net/mlx4_core: Removed unnecessary bit operation condition

Browse Source 
Fix the "warn: suspicious bitop condition" made by the smatch semantic
checker on:
drivers/net/ethernet/mellanox/mlx4/main.c:509 mlx4_slave_cap()

Signed-off-by: Eyal Perry <eyalpe@mellanox.com>
Signed-off-by: Amir Vadai <amirv@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eyal Perry
2014-05-14 12:15:14 +03:00
committed by David S. Miller
parent c05a116f39
commit 483e01320e
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/net/ethernet/mellanox/mlx4/main.c
View File

@@ -104,8 +104,6 @@ module_param(enable_64b_cqe_eqe, bool, 0444);
MODULE_PARM_DESC(enable_64b_cqe_eqe, MODULE_PARM_DESC(enable_64b_cqe_eqe,
"Enable 64 byte CQEs/EQEs when the FW supports this (default: True)"); "Enable 64 byte CQEs/EQEs when the FW supports this (default: True)");
#define HCA_GLOBAL_CAP_MASK 0
#define PF_CONTEXT_BEHAVIOUR_MASK MLX4_FUNC_CAP_64B_EQE_CQE #define PF_CONTEXT_BEHAVIOUR_MASK MLX4_FUNC_CAP_64B_EQE_CQE
static char mlx4_version[] = static char mlx4_version[] =
@@ -582,9 +580,10 @@ static int mlx4_slave_cap(struct mlx4_dev *dev)
return err; return err;
} }
/*fail if the hca has an unknown capability */ /* fail if the hca has an unknown global capability
if ((hca_param.global_caps | HCA_GLOBAL_CAP_MASK) != * at this time global_caps should be always zeroed
HCA_GLOBAL_CAP_MASK) { */
if (hca_param.global_caps) {
mlx4_err(dev, "Unknown hca global capabilities\n"); mlx4_err(dev, "Unknown hca global capabilities\n");
return -ENOSYS; return -ENOSYS;
} }