lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

libata-core: make sure that ata_force_tbl is freed in case of an error

Browse Source 
Fix a potential memory leak when ata_init() encounters an error.

Signed-off-by: Elias Oltmanns <eo@nebensachen.de>
Cc: Tejun Heo <tj@kernel.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
This commit is contained in:
Elias Oltmanns
2008-07-30 12:32:39 -07:00
committed by Jeff Garzik
parent 2486fa561a
commit 49ea3b0497
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/ata/libata-core.c
View File

@@ -6098,16 +6098,20 @@ static int __init ata_init(void)
ata_wq = create_workqueue("ata"); ata_wq = create_workqueue("ata");
if (!ata_wq) if (!ata_wq)
return -ENOMEM; goto free_force_tbl;
ata_aux_wq = create_singlethread_workqueue("ata_aux"); ata_aux_wq = create_singlethread_workqueue("ata_aux");
if (!ata_aux_wq) { if (!ata_aux_wq)
destroy_workqueue(ata_wq); goto free_wq;
return -ENOMEM;
}
printk(KERN_DEBUG "libata version " DRV_VERSION " loaded.\n"); printk(KERN_DEBUG "libata version " DRV_VERSION " loaded.\n");
return 0; return 0;
free_wq:
destroy_workqueue(ata_wq);
free_force_tbl:
kfree(ata_force_tbl);
return -ENOMEM;
} }
static void __exit ata_exit(void) static void __exit ata_exit(void)