lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

V4L/DVB (12527): tw9910: do not lie about cropping abilities

Browse Source 
The current tw9910 driver does not implement cropping correctly. Therefore, and
also because various rectangles in struct soc_camera_device are in user scale,
we cannot and shall not use rect_current as window location.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Guennadi Liakhovetski
2009-08-25 11:46:53 -03:00
committed by Mauro Carvalho Chehab
parent 94896298be
commit 4a5a5b2d62
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/media/video/tw9910.c
View File

@@ -719,9 +719,10 @@ static int tw9910_s_fmt(struct v4l2_subdev *sd, struct v4l2_format *f)
struct i2c_client *client = sd->priv; struct i2c_client *client = sd->priv;
struct soc_camera_device *icd = client->dev.platform_data; struct soc_camera_device *icd = client->dev.platform_data;
struct v4l2_pix_format *pix = &f->fmt.pix; struct v4l2_pix_format *pix = &f->fmt.pix;
/* See tw9910_set_crop() - no proper cropping support */
struct v4l2_rect rect = { struct v4l2_rect rect = {
.left = icd->rect_current.left, .left = 0,
.top = icd->rect_current.top, .top = 0,
.width = pix->width, .width = pix->width,
.height = pix->height, .height = pix->height,
}; };
@@ -850,6 +851,7 @@ static struct v4l2_subdev_ops tw9910_subdev_ops = {
* i2c_driver function * i2c_driver function
*/ */
/* This is called during probe, so, setting rect_max is Ok here: scale == 1 */
static void limit_to_scale(struct soc_camera_device *icd, static void limit_to_scale(struct soc_camera_device *icd,
const struct tw9910_scale_ctrl *scale) const struct tw9910_scale_ctrl *scale)
{ {