lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ASoC: Fix incorrect kfree in aic3x_probe error path

Browse Source 
We allocated memory for aic3x in aic3x_i2c_probe,
and will free the memory in either aic3x_i2c_probe error path or
aic3x_i2c_remove.

Thus we should not call kfree(aic3x) in aic3x_probe, otherwise
we have double free of aic3x.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
This commit is contained in:
Axel Lin
2010-11-16 16:09:41 +08:00
committed by Mark Brown
parent 50d0ac2e1e
commit 4ab867d276
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
sound/soc/codecs/tlv320aic3x.c
View File

@@ -1419,7 +1419,6 @@ err_get:
if (aic3x->gpio_reset >= 0) if (aic3x->gpio_reset >= 0)
gpio_free(aic3x->gpio_reset); gpio_free(aic3x->gpio_reset);
err_gpio: err_gpio:
kfree(aic3x);
return ret; return ret;
} }