[PATCH] Make most file operations structs in fs/ const
This is a conversion to make the various file_operations structs in fs/ const. Basically a regexp job, with a few manual fixups The goal is both to increase correctness (harder to accidentally write to shared datastructures) and reducing the false sharing of cachelines with things that get dirty in .data (while .rodata is nicely read only and thus cache clean) Signed-off-by: Arjan van de Ven <arjan@infradead.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
committed by
Linus Torvalds
parent
99ac48f54a
commit
4b6f5d20b0
@ -568,7 +568,7 @@ pipe_rdwr_open(struct inode *inode, struct file *filp)
|
||||
* The file_operations structs are not static because they
|
||||
* are also used in linux/fs/fifo.c to do operations on FIFOs.
|
||||
*/
|
||||
struct file_operations read_fifo_fops = {
|
||||
const struct file_operations read_fifo_fops = {
|
||||
.llseek = no_llseek,
|
||||
.read = pipe_read,
|
||||
.readv = pipe_readv,
|
||||
@ -580,7 +580,7 @@ struct file_operations read_fifo_fops = {
|
||||
.fasync = pipe_read_fasync,
|
||||
};
|
||||
|
||||
struct file_operations write_fifo_fops = {
|
||||
const struct file_operations write_fifo_fops = {
|
||||
.llseek = no_llseek,
|
||||
.read = bad_pipe_r,
|
||||
.write = pipe_write,
|
||||
@ -592,7 +592,7 @@ struct file_operations write_fifo_fops = {
|
||||
.fasync = pipe_write_fasync,
|
||||
};
|
||||
|
||||
struct file_operations rdwr_fifo_fops = {
|
||||
const struct file_operations rdwr_fifo_fops = {
|
||||
.llseek = no_llseek,
|
||||
.read = pipe_read,
|
||||
.readv = pipe_readv,
|
||||
|
Reference in New Issue
Block a user