lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

regulator: Fix obfuscated log messages

Browse Source 
Don't use %s to format fixed static strings into log messages, it just
makes searching for and reading the message in the kernel source
needlessly hard.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
This commit is contained in:
Mark Brown
2010-11-22 13:51:18 +00:00
committed by Liam Girdwood
parent 1d7372e15e
commit 4c35508fc0
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/regulator/core.c
View File

@@ -760,7 +760,7 @@ static int machine_constraints_voltage(struct regulator_dev *rdev,
/* else require explicit machine-level constraints */ /* else require explicit machine-level constraints */
if (cmin <= 0 || cmax <= 0 || cmax < cmin) { if (cmin <= 0 || cmax <= 0 || cmax < cmin) {
pr_err("%s '%s' voltage constraints\n", "invalid", pr_err("invalid '%s' voltage constraints\n",
name); name);
return -EINVAL; return -EINVAL;
} }
@@ -782,22 +782,20 @@ static int machine_constraints_voltage(struct regulator_dev *rdev,
/* final: [min_uV..max_uV] valid iff constraints valid */ /* final: [min_uV..max_uV] valid iff constraints valid */
if (max_uV < min_uV) { if (max_uV < min_uV) {
pr_err("%s '%s' voltage constraints\n", "unsupportable", pr_err("unsupportable '%s' voltage constraints\n",
name); name);
return -EINVAL; return -EINVAL;
} }
/* use regulator's subset of machine constraints */ /* use regulator's subset of machine constraints */
if (constraints->min_uV < min_uV) { if (constraints->min_uV < min_uV) {
pr_debug("override '%s' %s, %d -> %d\n", pr_debug("override '%s' min_uV, %d -> %d\n",
name, "min_uV", name, constraints->min_uV, min_uV);
constraints->min_uV, min_uV);
constraints->min_uV = min_uV; constraints->min_uV = min_uV;
} }
if (constraints->max_uV > max_uV) { if (constraints->max_uV > max_uV) {
pr_debug("override '%s' %s, %d -> %d\n", pr_debug("override '%s' max_uV, %d -> %d\n",
name, "max_uV", name, constraints->max_uV, max_uV);
constraints->max_uV, max_uV);
constraints->max_uV = max_uV; constraints->max_uV = max_uV;
} }
} }