netdevice: safe convert to netdev_priv() #part-2
We have some reasons to kill netdev->priv: 1. netdev->priv is equal to netdev_priv(). 2. netdev_priv() wraps the calculation of netdev->priv's offset, obviously netdev_priv() is more flexible than netdev->priv. But we cann't kill netdev->priv, because so many drivers reference to it directly. This patch is a safe convert for netdev->priv to netdev_priv(netdev). Since all of the netdev->priv is only for read. But it is too big to be sent in one mail. I split it to 4 parts and make every part smaller than 100,000 bytes, which is max size allowed by vger. Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
454d7c9b14
commit
4cf1653aa9
@@ -371,7 +371,7 @@ static int __devinit epic_init_one (struct pci_dev *pdev,
|
||||
#endif
|
||||
|
||||
pci_set_drvdata(pdev, dev);
|
||||
ep = dev->priv;
|
||||
ep = netdev_priv(dev);
|
||||
ep->mii.dev = dev;
|
||||
ep->mii.mdio_read = mdio_read;
|
||||
ep->mii.mdio_write = mdio_write;
|
||||
@@ -654,7 +654,7 @@ static void mdio_write(struct net_device *dev, int phy_id, int loc, int value)
|
||||
|
||||
static int epic_open(struct net_device *dev)
|
||||
{
|
||||
struct epic_private *ep = dev->priv;
|
||||
struct epic_private *ep = netdev_priv(dev);
|
||||
long ioaddr = dev->base_addr;
|
||||
int i;
|
||||
int retval;
|
||||
@@ -766,7 +766,7 @@ static int epic_open(struct net_device *dev)
|
||||
static void epic_pause(struct net_device *dev)
|
||||
{
|
||||
long ioaddr = dev->base_addr;
|
||||
struct epic_private *ep = dev->priv;
|
||||
struct epic_private *ep = netdev_priv(dev);
|
||||
|
||||
netif_stop_queue (dev);
|
||||
|
||||
@@ -789,7 +789,7 @@ static void epic_pause(struct net_device *dev)
|
||||
static void epic_restart(struct net_device *dev)
|
||||
{
|
||||
long ioaddr = dev->base_addr;
|
||||
struct epic_private *ep = dev->priv;
|
||||
struct epic_private *ep = netdev_priv(dev);
|
||||
int i;
|
||||
|
||||
/* Soft reset the chip. */
|
||||
@@ -841,7 +841,7 @@ static void epic_restart(struct net_device *dev)
|
||||
|
||||
static void check_media(struct net_device *dev)
|
||||
{
|
||||
struct epic_private *ep = dev->priv;
|
||||
struct epic_private *ep = netdev_priv(dev);
|
||||
long ioaddr = dev->base_addr;
|
||||
int mii_lpa = ep->mii_phy_cnt ? mdio_read(dev, ep->phys[0], MII_LPA) : 0;
|
||||
int negotiated = mii_lpa & ep->mii.advertising;
|
||||
@@ -863,7 +863,7 @@ static void check_media(struct net_device *dev)
|
||||
static void epic_timer(unsigned long data)
|
||||
{
|
||||
struct net_device *dev = (struct net_device *)data;
|
||||
struct epic_private *ep = dev->priv;
|
||||
struct epic_private *ep = netdev_priv(dev);
|
||||
long ioaddr = dev->base_addr;
|
||||
int next_tick = 5*HZ;
|
||||
|
||||
@@ -884,7 +884,7 @@ static void epic_timer(unsigned long data)
|
||||
|
||||
static void epic_tx_timeout(struct net_device *dev)
|
||||
{
|
||||
struct epic_private *ep = dev->priv;
|
||||
struct epic_private *ep = netdev_priv(dev);
|
||||
long ioaddr = dev->base_addr;
|
||||
|
||||
if (debug > 0) {
|
||||
@@ -913,7 +913,7 @@ static void epic_tx_timeout(struct net_device *dev)
|
||||
/* Initialize the Rx and Tx rings, along with various 'dev' bits. */
|
||||
static void epic_init_ring(struct net_device *dev)
|
||||
{
|
||||
struct epic_private *ep = dev->priv;
|
||||
struct epic_private *ep = netdev_priv(dev);
|
||||
int i;
|
||||
|
||||
ep->tx_full = 0;
|
||||
@@ -959,7 +959,7 @@ static void epic_init_ring(struct net_device *dev)
|
||||
|
||||
static int epic_start_xmit(struct sk_buff *skb, struct net_device *dev)
|
||||
{
|
||||
struct epic_private *ep = dev->priv;
|
||||
struct epic_private *ep = netdev_priv(dev);
|
||||
int entry, free_count;
|
||||
u32 ctrl_word;
|
||||
unsigned long flags;
|
||||
@@ -1087,7 +1087,7 @@ static void epic_tx(struct net_device *dev, struct epic_private *ep)
|
||||
static irqreturn_t epic_interrupt(int irq, void *dev_instance)
|
||||
{
|
||||
struct net_device *dev = dev_instance;
|
||||
struct epic_private *ep = dev->priv;
|
||||
struct epic_private *ep = netdev_priv(dev);
|
||||
long ioaddr = dev->base_addr;
|
||||
unsigned int handled = 0;
|
||||
int status;
|
||||
@@ -1155,7 +1155,7 @@ out:
|
||||
|
||||
static int epic_rx(struct net_device *dev, int budget)
|
||||
{
|
||||
struct epic_private *ep = dev->priv;
|
||||
struct epic_private *ep = netdev_priv(dev);
|
||||
int entry = ep->cur_rx % RX_RING_SIZE;
|
||||
int rx_work_limit = ep->dirty_rx + RX_RING_SIZE - ep->cur_rx;
|
||||
int work_done = 0;
|
||||
@@ -1306,7 +1306,7 @@ rx_action:
|
||||
static int epic_close(struct net_device *dev)
|
||||
{
|
||||
long ioaddr = dev->base_addr;
|
||||
struct epic_private *ep = dev->priv;
|
||||
struct epic_private *ep = netdev_priv(dev);
|
||||
struct sk_buff *skb;
|
||||
int i;
|
||||
|
||||
@@ -1356,7 +1356,7 @@ static int epic_close(struct net_device *dev)
|
||||
|
||||
static struct net_device_stats *epic_get_stats(struct net_device *dev)
|
||||
{
|
||||
struct epic_private *ep = dev->priv;
|
||||
struct epic_private *ep = netdev_priv(dev);
|
||||
long ioaddr = dev->base_addr;
|
||||
|
||||
if (netif_running(dev)) {
|
||||
@@ -1377,7 +1377,7 @@ static struct net_device_stats *epic_get_stats(struct net_device *dev)
|
||||
static void set_rx_mode(struct net_device *dev)
|
||||
{
|
||||
long ioaddr = dev->base_addr;
|
||||
struct epic_private *ep = dev->priv;
|
||||
struct epic_private *ep = netdev_priv(dev);
|
||||
unsigned char mc_filter[8]; /* Multicast hash filter */
|
||||
int i;
|
||||
|
||||
@@ -1416,7 +1416,7 @@ static void set_rx_mode(struct net_device *dev)
|
||||
|
||||
static void netdev_get_drvinfo (struct net_device *dev, struct ethtool_drvinfo *info)
|
||||
{
|
||||
struct epic_private *np = dev->priv;
|
||||
struct epic_private *np = netdev_priv(dev);
|
||||
|
||||
strcpy (info->driver, DRV_NAME);
|
||||
strcpy (info->version, DRV_VERSION);
|
||||
@@ -1425,7 +1425,7 @@ static void netdev_get_drvinfo (struct net_device *dev, struct ethtool_drvinfo *
|
||||
|
||||
static int netdev_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
|
||||
{
|
||||
struct epic_private *np = dev->priv;
|
||||
struct epic_private *np = netdev_priv(dev);
|
||||
int rc;
|
||||
|
||||
spin_lock_irq(&np->lock);
|
||||
@@ -1437,7 +1437,7 @@ static int netdev_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
|
||||
|
||||
static int netdev_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
|
||||
{
|
||||
struct epic_private *np = dev->priv;
|
||||
struct epic_private *np = netdev_priv(dev);
|
||||
int rc;
|
||||
|
||||
spin_lock_irq(&np->lock);
|
||||
@@ -1449,13 +1449,13 @@ static int netdev_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
|
||||
|
||||
static int netdev_nway_reset(struct net_device *dev)
|
||||
{
|
||||
struct epic_private *np = dev->priv;
|
||||
struct epic_private *np = netdev_priv(dev);
|
||||
return mii_nway_restart(&np->mii);
|
||||
}
|
||||
|
||||
static u32 netdev_get_link(struct net_device *dev)
|
||||
{
|
||||
struct epic_private *np = dev->priv;
|
||||
struct epic_private *np = netdev_priv(dev);
|
||||
return mii_link_ok(&np->mii);
|
||||
}
|
||||
|
||||
@@ -1504,7 +1504,7 @@ static const struct ethtool_ops netdev_ethtool_ops = {
|
||||
|
||||
static int netdev_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
|
||||
{
|
||||
struct epic_private *np = dev->priv;
|
||||
struct epic_private *np = netdev_priv(dev);
|
||||
long ioaddr = dev->base_addr;
|
||||
struct mii_ioctl_data *data = if_mii(rq);
|
||||
int rc;
|
||||
@@ -1532,7 +1532,7 @@ static int netdev_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
|
||||
static void __devexit epic_remove_one (struct pci_dev *pdev)
|
||||
{
|
||||
struct net_device *dev = pci_get_drvdata(pdev);
|
||||
struct epic_private *ep = dev->priv;
|
||||
struct epic_private *ep = netdev_priv(dev);
|
||||
|
||||
pci_free_consistent(pdev, TX_TOTAL_SIZE, ep->tx_ring, ep->tx_ring_dma);
|
||||
pci_free_consistent(pdev, RX_TOTAL_SIZE, ep->rx_ring, ep->rx_ring_dma);
|
||||
|
Reference in New Issue
Block a user