[PATCH] USB: UEAGLE : memory leack fix
this patch fix leak of memory allocated to intr if allocation of sc->urb_int fails. Found by the Coverity checker. Signed-off-by: Duncan Sands <baldrick@free.fr> Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
584958c3d2
commit
4d45e21867
@@ -1376,7 +1376,7 @@ static int uea_boot(struct uea_softc *sc)
|
|||||||
if (ret < 0) {
|
if (ret < 0) {
|
||||||
uea_err(INS_TO_USBDEV(sc),
|
uea_err(INS_TO_USBDEV(sc),
|
||||||
"urb submition failed with error %d\n", ret);
|
"urb submition failed with error %d\n", ret);
|
||||||
goto err1;
|
goto err;
|
||||||
}
|
}
|
||||||
|
|
||||||
sc->kthread = kthread_run(uea_kthread, sc, "ueagle-atm");
|
sc->kthread = kthread_run(uea_kthread, sc, "ueagle-atm");
|
||||||
@@ -1390,10 +1390,10 @@ static int uea_boot(struct uea_softc *sc)
|
|||||||
|
|
||||||
err2:
|
err2:
|
||||||
usb_kill_urb(sc->urb_int);
|
usb_kill_urb(sc->urb_int);
|
||||||
err1:
|
|
||||||
kfree(intr);
|
|
||||||
err:
|
err:
|
||||||
usb_free_urb(sc->urb_int);
|
usb_free_urb(sc->urb_int);
|
||||||
|
sc->urb_int = NULL;
|
||||||
|
kfree(intr);
|
||||||
uea_leaves(INS_TO_USBDEV(sc));
|
uea_leaves(INS_TO_USBDEV(sc));
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user