lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

PCI: pciehp: make check_link_active more helpful

Browse Source 
A few changes:
  - remove the 'inline' and let the complier decide
  - return a bool to indicate whether the link was active
  - add a debug message to indicate link state when it beocmes active

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
This commit is contained in:
Yinghai Lu
2012-01-27 10:55:12 -08:00
committed by Jesse Barnes
parent 2f5d8e4ff9
commit 4e2ce405b2
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/pci/hotplug/pciehp_hpc.c
View File

@@ -241,13 +241,20 @@ static int pcie_write_cmd(struct controller *ctrl, u16 cmd, u16 mask)
return retval; return retval;
} }
static inline int check_link_active(struct controller *ctrl) static bool check_link_active(struct controller *ctrl)
{ {
u16 link_status; bool ret = false;
u16 lnk_status;
if (pciehp_readw(ctrl, PCI_EXP_LNKSTA, &link_status)) if (pciehp_readw(ctrl, PCI_EXP_LNKSTA, &lnk_status))
return 0; return ret;
return !!(link_status & PCI_EXP_LNKSTA_DLLLA);
ret = !!(lnk_status & PCI_EXP_LNKSTA_DLLLA);
if (ret)
ctrl_dbg(ctrl, "%s: lnk_status = %x\n", __func__, lnk_status);
return ret;
} }
static void pcie_wait_link_active(struct controller *ctrl) static void pcie_wait_link_active(struct controller *ctrl)