lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tracing: fix sparse warnings: make symbols static

Browse Source 
Impact: make global variables and a global function static

The function '__trace_userstack' does not seem to have a caller, so it
is commented out.

Fix this sparse warnings:
  kernel/trace/trace.c:82:5: warning: symbol 'tracing_disabled' was not declared. Should it be static?
  kernel/trace/trace.c:600:10: warning: symbol 'trace_record_cmdline_disabled' was not declared. Should it be static?
  kernel/trace/trace.c:957:6: warning: symbol '__trace_userstack' was not declared. Should it be static?
  kernel/trace/trace.c:1694:5: warning: symbol 'tracing_release' was not declared. Should it be static?

Signed-off-by: Hannes Eder <hannes@hanneseder.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Hannes Eder
2009-02-10 19:44:12 +01:00
committed by Ingo Molnar
parent 4040068dce
commit 4fd2735881
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
kernel/trace/trace.c
View File

@@ -80,7 +80,7 @@ static int dummy_set_flag(u32 old_flags, u32 bit, int set)
* of the tracer is successful. But that is the only place that sets * of the tracer is successful. But that is the only place that sets
* this back to zero. * this back to zero.
*/ */
int tracing_disabled = 1; static int tracing_disabled = 1;
static DEFINE_PER_CPU(local_t, ftrace_cpu_disabled); static DEFINE_PER_CPU(local_t, ftrace_cpu_disabled);
@@ -626,7 +626,7 @@ static int cmdline_idx;
static DEFINE_SPINLOCK(trace_cmdline_lock); static DEFINE_SPINLOCK(trace_cmdline_lock);
/* temporary disable recording */ /* temporary disable recording */
atomic_t trace_record_cmdline_disabled __read_mostly; static atomic_t trace_record_cmdline_disabled __read_mostly;
static void trace_init_cmdlines(void) static void trace_init_cmdlines(void)
{ {
@@ -983,10 +983,12 @@ static void ftrace_trace_userstack(struct trace_array *tr,
#endif #endif
} }
void __trace_userstack(struct trace_array *tr, unsigned long flags) #ifdef UNUSED
static void __trace_userstack(struct trace_array *tr, unsigned long flags)
{ {
ftrace_trace_userstack(tr, flags, preempt_count()); ftrace_trace_userstack(tr, flags, preempt_count());
} }
#endif /* UNUSED */
static void static void
ftrace_trace_special(void *__tr, ftrace_trace_special(void *__tr,
@@ -1720,7 +1722,7 @@ int tracing_open_generic(struct inode *inode, struct file *filp)
return 0; return 0;
} }
int tracing_release(struct inode *inode, struct file *file) static int tracing_release(struct inode *inode, struct file *file)
{ {
struct seq_file *m = (struct seq_file *)file->private_data; struct seq_file *m = (struct seq_file *)file->private_data;
struct trace_iterator *iter = m->private; struct trace_iterator *iter = m->private;