lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Bluetooth: Remove return value from hci_send_frame() function

Browse Source 
The return value of hci_send_frame() is never checked. So just make
this function void and print an error when the hdev->send driver
callback returns a negative value.

Having the error printed is actually an improvement over the
current situation where any driver error just gets ignored.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
This commit is contained in:
Marcel Holtmann
2013-10-10 14:54:19 -07:00
committed by Johan Hedberg
parent 3d386acea0
commit 5108699194
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
net/bluetooth/hci_core.c
View File

@@ -2697,7 +2697,7 @@ int hci_unregister_cb(struct hci_cb *cb)
} }
EXPORT_SYMBOL(hci_unregister_cb); EXPORT_SYMBOL(hci_unregister_cb);
static int hci_send_frame(struct hci_dev *hdev, struct sk_buff *skb) static void hci_send_frame(struct hci_dev *hdev, struct sk_buff *skb)
{ {
BT_DBG("%s type %d len %d", hdev->name, bt_cb(skb)->pkt_type, skb->len); BT_DBG("%s type %d len %d", hdev->name, bt_cb(skb)->pkt_type, skb->len);
@@ -2717,7 +2717,8 @@ static int hci_send_frame(struct hci_dev *hdev, struct sk_buff *skb)
skb->dev = (void *) hdev; skb->dev = (void *) hdev;
return hdev->send(skb); if (hdev->send(skb) < 0)
BT_ERR("%s sending frame failed", hdev->name);
} }
void hci_req_init(struct hci_request *req, struct hci_dev *hdev) void hci_req_init(struct hci_request *req, struct hci_dev *hdev)